database support for PendingMgsUpdate for SP updates
#8291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgallagher
reviewed
Jun 17, 2025
|
The cleanup really wanted a rustfmt pass, but rustfmt hasn't been working on this code path. Fixing that added a bunch of noise so I split that into #8394 and made this PR dependent on that one. |
jgallagher
reviewed
Jun 23, 2025
| // TODO these need to be serialized to the database. | ||
| // See oxidecomputer/omicron#7981. | ||
| pending_mgs_updates: PendingMgsUpdates::new(), | ||
| pending_mgs_updates, | ||
| sleds: sled_configs, | ||
| parent_blueprint_id, | ||
| internal_dns_version, |
There was a problem hiding this comment.
It's below the diff, but:
a) I think we also need to update blueprint_delete, right?
b) I'm surprised we don't have any tests that caught this; do we need a test like we have for inventory that checks that deletion doesn't leave any leftovers behind in any of the bp_* tables?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly code-complete, the test is updated, and it appears to work.
Depends on #8394.
TODO: